-
Notifications
You must be signed in to change notification settings - Fork 457
chore: Add documentation for NetworkPrefab InstantiateWithData #3574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop-2.0.0
Are you sure you want to change the base?
Conversation
On thing is that I should have a PR today that will allow a PR to pass without tests running if it contains ONLY documentation changes (as should be the case with this PR). Another thing is that I wonder if instead of Added, Fixed we should introduce new category Doocumentation that would gather such changes? Asking since maybe current approach can be a bit confusing |
I think I like Added and Fixed in this context, it shows what files were changed. Not having to run all the Yamato checks would be magical! |
I should resolve the DOCS thingy together with PR template in #3577, but now I think that those should be separate PRs for more clarity. Will close this one and open 2 |
@NoelStephensUnity @EmandM I have #3580 that will optimize our CI workflows + allow us to avoid it when changes are only in Documentation~ folder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jabbacakes
Looks good to me from a content perspective, but we will wait for your approval (and any adjustments you might make) before merging.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pushed a commit with general grammar/style/wording updates. No major notes 👍
Great, @NoelStephensUnity should we merge it then so everything will be included for the release next week? |
Documentation for #3497
Changelog
Documentation
Testing & QA
Functional Testing
Manual testing :
Manual testing done
Automated tests:
Covered by existing automated tests
Covered by new automated tests
Does the change require QA team to:
Review automated tests
?Execute manual tests
?If any boxes above are checked, please add QA as a PR reviewer.
Backport
This is 2.x only documentation update and doesn't need a backport.